Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include node code #361

Merged
merged 1 commit into from
May 26, 2022
Merged

Do not include node code #361

merged 1 commit into from
May 26, 2022

Conversation

CGNonofr
Copy link
Collaborator

Including such code can break things by using the nodejs api like process

Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@CGNonofr CGNonofr merged commit fbf9db0 into main May 26, 2022
@CGNonofr CGNonofr deleted the do-not-include-node-code branch May 26, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants